Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Switch using ControlExampleSubstitution #479

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

MadEste
Copy link
Contributor

@MadEste MadEste commented Jun 26, 2020

Fixes #285

Description

Update Control Example so sample code reflects switch

Screenshots (if appropriate):

Types of changes

Used ControlExample Substitutions to bind toggle switch.

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. On a side note: Was there a specific reason you made this a draft PR @MadEste ?

@MadEste
Copy link
Contributor Author

MadEste commented Jun 26, 2020

@chingucoding Intern still learning the process. I'm validated now and will be submitting a pull request as a branch.

@stmoy
Copy link
Contributor

stmoy commented Jun 29, 2020

@MadEste - it looks like this PR is still in draft so I can't merge it. Please mark this PR as "ready for review" if it is ready to be merged.

@MadEste MadEste marked this pull request as ready for review June 29, 2020 17:16
@stmoy stmoy merged commit a945b54 into microsoft:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"A ToggleSwitch with custom header and title" sample should update code dynamically
3 participants