Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve animated visual player demo #480

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented Jun 29, 2020

Description

This improves the AnimatedVisual player demo

Motivation and Context

Closes #441

How Has This Been Tested?

Tested the following scenarios:

  • Play->Pause->Play->Pause
  • Play->Stop->Play
  • Play->Reverse->Pause->Play
  • Play->Reverse (wait for end)->Play
  • Play->Reverse -> Stop -> Play

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn
Copy link
Collaborator Author

@Poopooracoocoo FYI

@marcelwgn
Copy link
Collaborator Author

Update: I've fixed the sample now to return to the "play button" state once the animation finished playing. I think this now good to go feature wise.

@stmoy
Copy link
Contributor

stmoy commented Jun 30, 2020

@chingucoding - thank you for the improvements. Are there other changes in flight, or am I good to merge this now?

@marcelwgn
Copy link
Collaborator Author

Unless you have anything that you would like me to change, this is good to go.

@stmoy stmoy merged commit 3bd0944 into microsoft:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimatedVisualPlayer improvements
2 participants