Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RadioButtons page #493

Merged
merged 2 commits into from
Jul 10, 2020
Merged

RadioButtons page #493

merged 2 commits into from
Jul 10, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

This PR splits the RadioButton page into a sample for the RadioButton control and a sample for the RadioButtons control

Motivation and Context

Closes #490

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

stmoy
stmoy reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@stmoy stmoy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuliKl @chigy @kikisaints - y'all good with this PR?

XamlControlsGallery/ControlPages/RadioButtonsPage.xaml.cs Outdated Show resolved Hide resolved
stmoy
stmoy approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@stmoy stmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first pass and I want this included in the Store release I'm staging so approving this PR. If there is other feedback/changes needed later, we can follow up afterwards.

@stmoy stmoy merged commit 5ec0c07 into microsoft:master Jul 10, 2020
bpulliam pushed a commit that referenced this pull request Feb 1, 2022
@marcelwgn @bpulliam
RadioButtons page (#493)
ac7b07c 
* RadioButtons page

* Remove boilerplate comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmoy stmoy stmoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate RadioButtons sample into its own page
2 participants
@marcelwgn @stmoy