RadioButtons cleanup #500
Merged
RadioButtons cleanup #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g RadioButtons into the Layouts section and clarify wording
|
CC: @chingucoding |
marcelwgn
reviewed
Jul 11, 2020
|
I'm planning on pulling this in early afternoon today - @chingucoding, are you ok with the PR now that I've made some changes? |
marcelwgn
approved these changes
Jul 14, 2020
bpulliam
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Clarify the distinction between RadioButton and RadioButtons by moving RadioButtons into the Layouts section and clarify wording * Remove unnecessary RelativePanel, update wording in json file * Clean up RadioButton sample. * Adding RadioButtons icon to differentiate from RadioButton * Add sample code substitution for SelectedIndex on RadioButtons page. * Responding to PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change further delineates the samples for RadioButton vs. RadioButtons. Previously they shared an icon, were found in the same category, etc. - this change moves RadioButtons to Layouts and updates the wording for both samples.
Motivation and Context
RadioButton and RadioButtons are related, but conceptually different. This change further differentiates the two samples.
How Has This Been Tested?
Manual testing.
Screenshots (if appropriate):
Types of changes