Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resized assets to have standard icon size #505

Merged
merged 7 commits into from
Jul 20, 2020

Conversation

Spyromaniac31
Copy link

Description

Resized the icons in the Start Menu tile and splash screen assets to better match the standard icon size seen across Microsoft apps

Added a drop shadow to the Start Menu and splash screen assets to match the drop shadow in official Microsoft fluent icons.

Motivation and Context

Helps XCG fit better with other apps on the Start Menu and makes the icon a better size in the Microsoft Store
App Icon in Store is too small

How Has This Been Tested?

Icon scaled to a size that looks consistent next to other Start Menu tiles

Screenshots (if appropriate):

image
Right is current, middle is proposed. Text will be on the actual one.

Types of changes

Sort of N/A

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ghost
Copy link

ghost commented Jul 19, 2020

CLA assistant check
All CLA requirements met.

@Spyromaniac31
Copy link
Author

The reason there are 7 commits is because I forgot to reference the issue in the commit message and but I also wanted to make sure the final commit showed the actual changes. Sorry about that.

@marcelwgn
Copy link
Collaborator

No problem, happy that created a PR for this. A few infos on GitHub and this repository:

If you add "Fixes #x" to a PR description, it will close the issue with the number x when the PR get's merged. That means you don't have to include it in your commit message.

It's no problem that you created 7 commits, on this and a lot of other repositories, the PR will get squash-merged, that means all commits get squashed into a single one.

If you have any questions, feel free to ask :)

@stmoy
Copy link
Contributor

stmoy commented Jul 20, 2020

@Spyromaniac31 - these look awesome :) Thank you for doing this!

@stmoy stmoy merged commit 62e7b17 into microsoft:master Jul 20, 2020
@Spyromaniac31
Copy link
Author

@chingucoding I appreciate the tip. I'll let you know if I have any other questions.

@stmoy Glad you like them! Can't wait for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants