Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text regarding material fallbacks #557

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

Add text at the top of acrylic and reveal page to explain when fallback is used.

There does not seem to be a document on reveal fallback behavior, was that missed or did I simply not find it @licanhua ?

Motivation and Context

Closes #553

How Has This Been Tested?

Visit page and click link.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@stmoy
Copy link
Contributor

stmoy commented Sep 14, 2020

CC: @kikisaints do we have docs that describe when/how reveal goes into fallback mode?

Co-authored-by: Steven Moyes <stmoy@microsoft.com>
@stmoy stmoy merged commit a9c0242 into microsoft:master Nov 30, 2020
bpulliam pushed a commit that referenced this pull request Feb 1, 2022
* Add text regarding material fallbacks

* Apply suggestions from code review

Co-authored-by: Steven Moyes <stmoy@microsoft.com>

Co-authored-by: Steven Moyes <stmoy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide meaningful output to user when Acrylic or Reveal is in fallback mode
2 participants