Add debug manifest file for development #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpulliam
approved these changes
Jun 13, 2022
| xmlns:uap3="http://schemas.microsoft.com/appx/manifest/uap/windows10/3" | ||
| xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" | ||
| IgnorableNamespaces="uap mp uap3"> | ||
| <Identity Name="Microsoft.WinUI3ControlsGallery.Debug" Publisher="CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US" Version="1.3.13.0" /> |
There was a problem hiding this comment.
Suggestion: use Dev instead of Debug in both the name and filename. Following the Terminal model, we can introduce branding (not necessarily in this PR) so that "WinUI 3 Gallery" is always Release, "WinUI 3 Gallery Dev" is the default and can be Debug or Release
There was a problem hiding this comment.
I see what you are going after here. So would it be better to rename this to dev and make it the default for both debug and release and keep the "non-dev" version up just for building the store version?
3 tasks
bpulliam
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the WinUI 2 gallery, this PR adds a debug manifest that allows you to have the Store version and the development versions installed at the same time instead of the two versions overriding each other all the time.
Question: Right now the app would still display WinUI 3 Gallery when being started, is that good?