Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsfilters isolation updates #1013

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Fsfilters isolation updates #1013

merged 7 commits into from
Oct 4, 2023

Conversation

zlockard
Copy link
Collaborator

@zlockard zlockard commented Aug 1, 2023

No description provided.

@zlockard zlockard requested a review from a team as a code owner September 27, 2023 20:32
Copy link
Contributor

@cgallred cgallred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to put version checks in public samples; checking the OS version is not the best way to determine whether a feature exists. Besides that, the samples won't build on a version of Windows that doesn't have IoOpenDriverRegistryKey exported anyway, so the version check doesn't help.

Instead, you should use the MmGetSystemRoutineAddress function to probe for the existence of IoOpenDriverRegistryKey, and then use it if it exists.

@zlockard
Copy link
Collaborator Author

We do not want to put version checks in public samples; checking the OS version is not the best way to determine whether a feature exists. Besides that, the samples won't build on a version of Windows that doesn't have IoOpenDriverRegistryKey exported anyway, so the version check doesn't help.

Instead, you should use the MmGetSystemRoutineAddress function to probe for the existence of IoOpenDriverRegistryKey, and then use it if it exists.

Yeah if you look at the latest cancelsafe in this PR it uses MmGetSystemRoutineAddress, we're still looking at what code paradigm we want for this

@zlockard zlockard requested a review from cgallred October 2, 2023 22:18
@zlockard zlockard merged commit 06b3305 into develop Oct 4, 2023
8 checks passed
@zlockard zlockard deleted the fsfilters_version_updates branch October 30, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants