Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements to build scripts #1240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NeoAdonis
Copy link
Member

This pull request includes a few improvements and fixes to the Build-Sample.ps1 and Build-SampleSet.ps1 scripts to enhance readability, maintainability, and functionality.

  • Build-Sample.ps1: Changed the loop condition to use -lt 3 (less than) to understand better the upper limit of build attempts.
  • Added handling for binary log file creation to help diagnose issues when a build fails.
  • Replaced shortcuts with long expressions for better readability and to remove warnings.
  • Fix issue where building samples using the EWDK was not supported by the build scripts.
  • Other minor whitespace fixes.

@NeoAdonis NeoAdonis requested a review from a team as a code owner November 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants