adjust to use exception handling to avoid a crash in glyph handling #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce glyph in DisplayHelpers.cs...els
…ovement by the center...els
…sting mixing of dynamically created input streams. The sample uses 5% of the CPU, but gets glitchy with too many notes. Remember, though, we're running UWP C#, and .NET, and in this particular test we're getting an interrupt every 250uS or so. that's pretty wonky for UWP I think, especially considering there probobly is no way to set a realtime priority or anything. So we're defintely in user mode, and just normal priority....els
… we can compare the efficiency when there is more input data and just fewer interupts...[but the scenario doens't work yet] els
…supports stereo, so we do save something, but not the kind of savings I was hoping for....els
oldnewthing
force-pushed
the
master
branch
6 times, most recently
from
2239d7f
to
9bf6501
Compare
|
Incorporated into release v13.0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In UpdateGlyphBitmapImage, we just seem too prone to classes with (I guess) poorly built or incomplete device packages. This could be a windows thing in the latest 17682 Insider release, or something else, but without the exception handling, we crash constantly.
Not rocket surgery, just put a try/catch around the calls. I'm sure there are more complete ways to do this.