Taskbar is still there in full screen mode entered from maximized window

[kingcean]

Describe the bug

The taskbar is not covered if the window was maximized before entering full screen.

Steps to reproduce the bug

1. Maximize the window.
2. Enter full screen.

Expected behavior

The taskbar should disappear until the window closes or exits from full screen.

Screenshots

↑ Maximize window

↑ Then enter full screen (but you can still see the taskbar)

NuGet package version

1.1.0

Packaging type

Packaged (MSIX)

Windows version

Windows 11 version 21H2 (22000)

IDE

Visual Studio 2022

Additional context

No response

[marb2000]

Hey @kingcean do you have a repro so we can take a look at the APIs that you are using?

[kingcean]

Yes. You can maximize the window first (by programming or by clicking/tapping the caption button), and then enter full screen to have a look.

// var appWindow = ... The AppWindow instance of MainWindow.
var presenter = appWindow.Presenter as Microsoft.UI.Windowing.OverlappedPresenter;
presenter.Maximize();
appWindow.SetPresenter(Microsoft.UI.Windowing.AppWindowPresenterKind.FullScreen);

[riverar]

This repros 100% if window is in maximized state before fullscreen presenter is set.

Repro project:
was_issue_2577.zip

AppWindow seems to really unreliable and a continuous source of bugs. Would recommend increasing test suite coverage and engineering scrutiny on AppWindow classes.

[dotMorten]

I can repro this with the WinUIEx Sample app. Just run the app, maximize window, then select the "Fullscreen" presenter in the presenter dropdown. My app restores to the non-maximized state when I do this, yet claims to be fullscreen.

[rkarman]

Yeah, this one should not have been able to slip through the automated tests. 😞 I've logged a task for the dev team and we'll be adding it to a servicing release as soon as we have a fix.

MSFT dev team tracking: http://task.ms/39908320

[kingcean]

I can still repro this on Windows App SDK 1.1.1.

[koenvd]

Still reproducible with Windows App SDK 1.1.4.

[stevewri]

Thanks! 😊 From: Roberth Karman ***@***.***> Sent: Tuesday, November 1, 2022 10:52 AM To: microsoft/WindowsAppSDK ***@***.***> Cc: Steve Wright ***@***.***>; Assign ***@***.***> Subject: Re: [microsoft/WindowsAppSDK] Taskbar is still there in full screen mode entered from maximized window (Issue #2577) Assigned #2577<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fmicrosoft%2FWindowsAppSDK%2Fissues%2F2577&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AfrBvknii4pm%2FWbCby8N2hSqq5t9Jj%2Fdf2ix8%2B7f2nY%3D&reserved=0> to @stevewri<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fstevewri&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kmqduRzEM%2B2zr%2Biha5J91FTfJxIiQvwkIJ8K8vskoVE%3D&reserved=0>. — Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fmicrosoft%2FWindowsAppSDK%2Fissues%2F2577%23event-7715769233&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VweWRhdOBxSeegyhz5yIXKR%2BfvWczoWv3tK6Coq68z8%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FAPVPIIZJJAZDKBR77KR7MYLWGFKDTANCNFSM5X5DVN6Q&data=05%7C01%7Cswright%40microsoft.com%7C25a4c1651be74407bfcc08dabc31c341%7C72f988bf86f141af91ab2d7cd011db47%7C0%7C0%7C638029219194454300%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tQM9ulz%2BjephHFeet7Rtv2tzoFNP%2FQ732QyDXFopmSU%3D&reserved=0>. You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>

[kingcean]

Fixed - v1.2.
However, if you exit full screen and restore, the window size is not the one before maximizing and entering full screen. For example, set window size to 1000x600 → maximize → enter full screen → exit full screen → restore, then the window size is not 1000x600 anymore but fill the screen.