Skip to content

Commit

Permalink
Merged PR 7443436: Check NRPC support early
Browse files Browse the repository at this point in the history
## Pull Request Checklist
### General
- [ ] Are all regression test passed?
- [ ] Are there any test cases that will expose unfixed TDIs or Windows bugs?

### New Test Case
- [ ] Have Design Spec and User Guide been updated?
- [ ] Can all the test cases be loaded and executed by PTM & PTMCli?
- [ ] Can the related changes support multiple platform(Windows, Linux, MacOS)?

### SDK Changes
- [ ] Are all related test suites Regression passed?
  • Loading branch information
obaro committed Jun 7, 2022
1 parent 67bf86e commit 5310900
Showing 1 changed file with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ protected override void TestInitialize()
{
base.TestInitialize();

CheckDriverSupportsNRPC();

if (dynamicallyConfigurableShareName == null)
{
dynamicallyConfigurableShareName = TestConfig.SharePermissionTestShare;
Expand Down Expand Up @@ -74,7 +76,6 @@ protected override void TestCleanup()
"ACCESS_ALLOWED_ACE with user SID exists in share Security Descriptor.")]
public void BVT_SharePermission_AccessAllow_UserSid()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetUserSid(azUser01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand All @@ -101,7 +102,6 @@ public void BVT_SharePermission_AccessAllow_UserSid()
"ACCESS_ALLOWED_ACE with user's group SID exists in share Security Descriptor.")]
public void SharePermission_AccessAllow_GroupSid()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetGroupSid(azGroup01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand Down Expand Up @@ -130,7 +130,6 @@ public void SharePermission_AccessAllow_GroupSid()
"ACCESS_DENIED_ACE with user SID exists in share Security Descriptor.")]
public void SharePermission_AccessDeny_UserSid()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetUserSid(azUser01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand All @@ -157,7 +156,6 @@ public void SharePermission_AccessDeny_UserSid()
"ACCESS_DENIED_ACE with user's group SID exists in share Security Descriptor.")]
public void SharePermission_AccessDeny_GroupSid()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetGroupSid(azGroup01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand Down Expand Up @@ -186,7 +184,6 @@ public void SharePermission_AccessDeny_GroupSid()
"user SID does not exist in share Security Descriptor.")]
public void SharePermission_AccessDeny_SidNoInclude()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetUserSid(azUser01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand All @@ -213,7 +210,6 @@ public void SharePermission_AccessDeny_SidNoInclude()
"ACCESS_ALLOWED_ACE with user SID exists in share Security Descriptor.")]
public void SharePermission_AccessDeny_UserSidWithoutReadPermission()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetUserSid(azUser01Name);
string shareName;
if (dynamicallyConfigurableShareExist)
Expand Down Expand Up @@ -241,7 +237,6 @@ public void SharePermission_AccessDeny_UserSidWithoutReadPermission()
[Description("This case is designed to test whether server can handle file deletion request when Treeconnect.MaximalAccess does not include DELETE or GENERIC_ALL.")]
public void SharePermission_CreateClose_DeleteFile_MaximalAccessNotIncludeDeleteOrGenericAll()
{
CheckDriverSupportsNRPC();
_SID sid = sutCommonControlAdapterAccessor.GetUserSid(azUser01Name);
if (!dynamicallyConfigurableShareExist)
{
Expand Down

0 comments on commit 5310900

Please sign in to comment.