Update CVE-2021-42306-AutomationAssessAndMitigate.ps1 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the code to include next page query for getting all automation accounts, as if more than 1000 accounts are accessible to current user, they are not added to collection. Using top = 10000 didn't work as result set cannot exceed maximum value of 1000 returned records: https://docs.microsoft.com/en-us/azure/governance/resource-graph/concepts/work-with-data#paging-results Execution of Get-AzAccessToken cmdlet was moved from beginning of the script to Make-MSGraphRequest function to ensure access token is being refreshed. In other case script is failing if it is running for more than 1 hour (beyond the lifetime of the initially obtained access token), as there is no validation if access token is not expired.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to include next page query for getting all automation accounts, as if more than 1000 accounts are accessible to current user, they are not added to collection. Using top = 10000 didn't work as result set cannot exceed maximum value of 1000 returned records:
https://docs.microsoft.com/en-us/azure/governance/resource-graph/concepts/work-with-data#paging-results
Execution of Get-AzAccessToken cmdlet was moved from beginning of the script to Make-MSGraphRequest function to ensure access token is being refreshed. In other case script is failing if it is running for more than 1 hour (beyond the lifetime of the initially obtained access token), as there is no validation if access token is not expired.