feat(fluentUI-migration): ActionButton fluentui v8 to v9 migration #8084
ci.yml
on: pull_request
Matrix: unit-tests
build
1m 1s
lints
1m 25s
codeql
2m 35s
e2e-report-tests
46s
check-clearly-defined
9s
Matrix: e2e-web-tests
publish-code-coverage
0s
Annotations
30 errors and 2 warnings
e2e-report-tests
Process completed with exit code 1.
|
build:
src/DetailsView/components/command-bar-buttons-menu.tsx#L13
'NamedFC' is declared but its value is never read.
|
build:
src/DetailsView/components/report-export-button.tsx#L7
'ButtonRefFunction' is declared but its value is never read.
|
build:
src/DetailsView/components/save-assessment-button-factory.tsx#L43
Property 'buttonRef' is missing in type '{ deps: SaveAssessmentButtonFactoryDeps; assessmentStoreData: AssessmentStoreData; tabStoreData: TabStoreData; ... 4 more ...; href: string; }' but required in type 'SaveAssessmentButtonProps'.
|
build:
src/DetailsView/components/start-over-component-factory.tsx#L10
'ButtonRefFunction' is declared but its value is never read.
|
build:
src/DetailsView/components/start-over-dropdown.tsx#L17
'ButtonRefFunction' is declared but its value is never read.
|
build:
src/DetailsView/components/transfer-to-assessment-button.tsx#L8
'ButtonRefFunction' is declared but its value is never read.
|
build:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L611
'DetailsViewCommandBar' refers to a value, but is being used as a type here. Did you mean 'typeof DetailsViewCommandBar'?
|
build:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L612
Only a void function can be called with the 'new' keyword.
|
build:
src/tests/unit/tests/DetailsView/components/report-export-button.test.tsx#L28
Type 'ButtonRefFunction' is not assignable to type 'RefObject<HTMLAnchorElement | HTMLButtonElement>'.
|
build:
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx#L40
Property 'buttonRef' is missing in type '{ deps: { getAssessmentActionMessageCreator: () => AssessmentActionMessageCreator; userConfigMessageCreator: UserConfigMessageCreator; }; download: string; href: string; userConfigurationStoreData: UserConfigurationStoreData; handleSaveAssesmentButtonClick: (event: React.MouseEvent<any>) => void; }' but required in type 'SaveAssessmentButtonProps'.
|
lints:
src/DetailsView/components/details-view-command-bar.tsx#L57
`react` import should occur before import of `reports/report-generator`
|
lints:
src/DetailsView/components/details-view-command-bar.tsx#L310
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
|
lints:
src/DetailsView/components/details-view-command-bar.tsx#L350
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
|
lints:
src/DetailsView/components/start-over-component-factory.tsx#L26
`react` import should occur before import of `./start-over-menu-item.scss`
|
lints:
src/DetailsView/components/start-over-dropdown.tsx#L32
`react` import should occur before import of `./details-view-right-panel`
|
lints
Process completed with exit code 1.
|
DetailsViewCommandBar › renders null when tab closed:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L612
TypeError: _detailsviewcommandbar.DetailsViewCommandBar is not a constructor
at getTestSubject (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:612:16)
at getTestSubject (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:606:29)
at Object.renderTest (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:318:16)
|
DetailsViewCommandBar › renders with buttons collapsed into a menu:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L325
Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
Check the render method of `ForwardRef(mockConstructor)`.
at createFiberFromTypeAndProps (node_modules/react-dom/cjs/react-dom.development.js:28478:17)
at createFiberFromElement (node_modules/react-dom/cjs/react-dom.development.js:28504:15)
at reconcileSingleElement (node_modules/react-dom/cjs/react-dom.development.js:13986:23)
at reconcileChildFibers (node_modules/react-dom/cjs/react-dom.development.js:14044:35)
at reconcileChildren (node_modules/react-dom/cjs/react-dom.development.js:19186:28)
at updateForwardRef (node_modules/react-dom/cjs/react-dom.development.js:19277:3)
at beginWork (node_modules/react-dom/cjs/react-dom.development.js:21675:16)
at beginWork$1 (node_modules/react-dom/cjs/react-dom.development.js:27465:14)
at performUnitOfWork (node_modules/react-dom/cjs/react-dom.development.js:26599:12)
at workLoopSync (node_modules/react-dom/cjs/react-dom.development.js:26505:5)
at renderRootSync (node_modules/react-dom/cjs/react-dom.development.js:26473:7)
at recoverFromConcurrentError (node_modules/react-dom/cjs/react-dom.development.js:25889:20)
at performConcurrentWorkOnRoot (node_modules/react-dom/cjs/react-dom.development.js:25789:22)
at flushActQueue (node_modules/react/cjs/react.development.js:2667:24)
at act (node_modules/react/cjs/react.development.js:2582:11)
at node_modules/@testing-library/react/dist/act-compat.js:47:25
at renderRoot (node_modules/@testing-library/react/dist/pure.js:180:26)
at render (node_modules/@testing-library/react/dist/pure.js:271:10)
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:325:36)
|
DetailsViewCommandBar › renders save assessment dialog:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L370
TypeError: Cannot read properties of undefined (reading 'isOpen')
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:370:72)
|
DetailsViewCommandBar › renders start test over dialog:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L406
TypeError: Cannot read properties of undefined (reading 'dialogState')
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:406:67)
|
DetailsViewCommandBar › renders start assessment over dialog:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L421
TypeError: Cannot read properties of undefined (reading 'dialogState')
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:421:67)
|
DetailsViewCommandBar › Button focus › do not change focus to transfer assessment button when focus ref is not set:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L506
TypeError: setRef is not a function
at Object.setRef (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:506:13)
|
DetailsViewCommandBar › Button focus › do not change focus to start over button when focus ref is not set:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L541
TypeError: Cannot read properties of undefined (reading 'dismissDialog')
at src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:541:57
at node_modules/@testing-library/react/dist/act-compat.js:48:24
at act (node_modules/react/cjs/react.development.js:2512:16)
at node_modules/@testing-library/react/dist/act-compat.js:47:25
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:540:16)
|
DetailsViewCommandBar › Button focus › focus start over button when focus ref is set:
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx#L567
TypeError: Cannot read properties of undefined (reading 'dismissDialog')
at src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:567:57
at node_modules/@testing-library/react/dist/act-compat.js:48:24
at act (node_modules/react/cjs/react.development.js:2512:16)
at node_modules/@testing-library/react/dist/act-compat.js:47:25
at Object.<anonymous> (src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx:566:16)
|
unit-tests (1/2)
Process completed with exit code 1.
|
CommandBarButtonsMenu › renders CommandBarButtonsMenu:
src/tests/unit/tests/DetailsView/components/command-bar-buttons-menu.test.tsx#L50
expect(received).toMatchSnapshot()
Snapshot name: `CommandBarButtonsMenu renders CommandBarButtonsMenu 1`
- Snapshot - 7
+ Received + 0
@@ -4,27 +4,20 @@
relationship="label"
>
<mock-menu
open="false"
>
- <mock-tooltip
- content="More actions"
- positioning="below-end"
- relationship="label"
- witharrow="true"
- >
<mock-menutrigger
disablebuttonenhancement="true"
>
<mock-menubutton
appearance="transparent"
aria-label="More actions"
classname="commandBarButtonsMenuButton"
icon="[object Object]"
/>
</mock-menutrigger>
- </mock-tooltip>
<mock-menupopover
style="border-radius: unset !important;"
>
<mock-menulist
classname="menuList"
at Object.toMatchSnapshot (src/tests/unit/tests/DetailsView/components/command-bar-buttons-menu.test.tsx:50:38)
at runMicrotasks (<anonymous>)
|
unit-tests (2/2)
Process completed with exit code 1.
|
Details View -> Overview Page › should display pinned results when loading web@2.26.0-valid-mixed-results.a11ywebassessment:
src/tests/end-to-end/common/page-controllers/page.ts#L102
page.waitForSelector: Timeout 10000ms exceeded.
Call log:
- waiting for locator('[data-automation-id="outcome-summary-bar"]:not([aria-label="0% Passed, 100% Incomplete, 0% Failed"])') to be visible
at waitForSelector (src/tests/end-to-end/common/page-controllers/page.ts:102:43)
at wrappedFunction (src/tests/end-to-end/common/screenshot-on-error.ts:22:22)
at DetailsViewPage.screenshotOnError (src/tests/end-to-end/common/page-controllers/page.ts:200:39)
at DetailsViewPage.screenshotOnError (src/tests/end-to-end/common/page-controllers/page.ts:100:27)
at waitForSelector (src/tests/end-to-end/tests/details-view/overview.test.ts:62:28)
|
e2e-web-tests (2/2)
Process completed with exit code 1.
|
codeql
This run of the CodeQL Action does not have permission to access Code Scanning API endpoints. As a result, it will not be opted into any experimental features. This could be because the Action is running on a pull request from a fork. If not, please ensure the Action has the 'security-events: write' permission. Details: Resource not accessible by integration
|
codeql
Feature flags do not specify a default CLI version. Falling back to the CLI version shipped with the Action. This is 2.18.2.
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
e2e-report-tests-results
|
1.28 KB |
|
e2e-web-tests-1-results
|
6.84 KB |
|
e2e-web-tests-2-debug-logs
|
77.2 MB |
|
e2e-web-tests-2-results
|
2.34 KB |
|
unit-tests-1-results
|
156 KB |
|
unit-tests-2-results
|
157 KB |
|