Skip to content

Commit

Permalink
Fix tslint warnings in action-payloads, messages, global-action-creat…
Browse files Browse the repository at this point in the history
…or (#162)

I'm touching these files in feature work and want to clean up tslint warnings, but don't want to do that in the feature PR since the changes (mostly removing the leading I from interfaces) touch a pile of files which would be a distraction for reviewers. Changes in this PR are only mechanical F2 renames.
  • Loading branch information
peterdur committed Feb 6, 2019
1 parent f7f7690 commit 51b3e5c
Show file tree
Hide file tree
Showing 40 changed files with 401 additions and 401 deletions.
60 changes: 30 additions & 30 deletions src/DetailsView/actions/details-view-action-message-creator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,24 @@
// Licensed under the MIT License.
import { autobind } from '@uifabric/utilities';

import { IOnDetailsViewPivotSelected, ISelectTestStepPayload } from '../../background/actions/action-payloads';
import { OnDetailsViewPivotSelected, SelectTestStepPayload } from '../../background/actions/action-payloads';
import { Messages } from '../../common/messages';
import { DevToolActionMessageCreator } from '../../common/message-creators/dev-tool-action-message-creator';
import { DetailsViewPivotType } from '../../common/types/details-view-pivot-type';
import { ManualTestStatus } from '../../common/types/manual-test-status';
import {
BaseActionPayload,
IAddFailureInstancePayload,
IAssessmentActionInstancePayload,
IAssessmentToggleActionPayload,
IChangeAssessmentStepStatusPayload,
IChangeInstanceSelectionPayload,
IChangeInstanceStatusPayload,
IEditFailureInstancePayload,
IOnDetailsViewOpenPayload,
IRemoveFailureInstancePayload,
ISwitchToTargetTabPayLoad,
IToggleActionPayload,
AddFailureInstancePayload,
AssessmentActionInstancePayload,
AssessmentToggleActionPayload,
ChangeAssessmentStepStatusPayload,
ChangeInstanceSelectionPayload,
ChangeInstanceStatusPayload,
EditFailureInstancePayload,
OnDetailsViewOpenPayload,
RemoveFailureInstancePayload,
SwitchToTargetTabPayload,
ToggleActionPayload,
} from './../../background/actions/action-payloads';
import { IFeatureFlagPayload } from './../../background/actions/feature-flag-actions';
import { TelemetryDataFactory } from './../../common/telemetry-data-factory';
Expand Down Expand Up @@ -145,7 +145,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
}

public selectDetailsView(event: React.MouseEvent<HTMLElement>, type: VisualizationType, pivot: DetailsViewPivotType): void {
const payload: IOnDetailsViewOpenPayload = {
const payload: OnDetailsViewOpenPayload = {
telemetry: this.telemetryFactory.forSelectDetailsView(event, type),
detailsViewType: type,
pivotType: pivot,
Expand All @@ -159,7 +159,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
}

public selectTestStep(event: React.MouseEvent<HTMLElement>, selectedStep: string, type: VisualizationType): void {
const payload: ISelectTestStepPayload = {
const payload: SelectTestStepPayload = {
telemetry: this.telemetryFactory.forSelectTestStep(event, type, selectedStep),
selectedStep: selectedStep,
selectedTest: type,
Expand All @@ -175,7 +175,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
public sendPivotItemClicked(pivotKey: string, ev?: React.MouseEvent<HTMLElement>): void {
const telemetry = this.telemetryFactory.forDetailsViewNavPivotActivated(ev, pivotKey);

const payload: IOnDetailsViewPivotSelected = {
const payload: OnDetailsViewPivotSelected = {
telemetry: telemetry,
pivotKey: DetailsViewPivotType[pivotKey],
};
Expand All @@ -190,7 +190,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public switchToTargetTab(event: React.MouseEvent<HTMLElement>): void {
const telemetry = this.telemetryFactory.fromDetailsView(event);
const payload: ISwitchToTargetTabPayLoad = {
const payload: SwitchToTargetTabPayload = {
telemetry,
};
this.dispatchMessage({
Expand All @@ -202,7 +202,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public startOverAssessment(event: React.MouseEvent<any>, test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.forAssessmentActionFromDetailsView(test, event);
const payload: IToggleActionPayload = {
const payload: ToggleActionPayload = {
test,
step,
telemetry,
Expand All @@ -217,7 +217,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public enableVisualHelper(test: VisualizationType, step: string, shouldScan = true, sendTelemetry = true): void {
const telemetry = sendTelemetry ? this.telemetryFactory.forAssessmentActionFromDetailsViewNoTriggeredBy(test) : null;
const payload: IAssessmentToggleActionPayload = {
const payload: AssessmentToggleActionPayload = {
test,
step,
telemetry,
Expand All @@ -231,7 +231,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
}

public disableVisualHelpersForTest(test: VisualizationType): void {
const payload: IToggleActionPayload = {
const payload: ToggleActionPayload = {
test,
};

Expand All @@ -244,7 +244,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public disableVisualHelper(test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IToggleActionPayload = {
const payload: ToggleActionPayload = {
test,
telemetry,
};
Expand All @@ -259,7 +259,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public changeManualTestStatus(status: ManualTestStatus, test: VisualizationType, step: string, selector: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IChangeInstanceStatusPayload = {
const payload: ChangeInstanceStatusPayload = {
test,
step,
status,
Expand All @@ -277,7 +277,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public changeManualTestStepStatus(status: ManualTestStatus, test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IChangeAssessmentStepStatusPayload = {
const payload: ChangeAssessmentStepStatusPayload = {
test,
step,
status,
Expand All @@ -294,7 +294,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public undoManualTestStatusChange(test: VisualizationType, step: string, selector: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IAssessmentActionInstancePayload = {
const payload: AssessmentActionInstancePayload = {
test,
step,
selector,
Expand All @@ -311,7 +311,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public undoManualTestStepStatusChange(test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.fromDetailsViewNoTriggeredBy();
const payload: IChangeAssessmentStepStatusPayload = {
const payload: ChangeAssessmentStepStatusPayload = {
test: test,
step: step,
telemetry: telemetry,
Expand All @@ -332,7 +332,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
selector: string,
): void {
const telemetry = this.telemetryFactory.fromDetailsViewNoTriggeredBy();
const payload: IChangeInstanceSelectionPayload = {
const payload: ChangeInstanceSelectionPayload = {
test,
step,
isVisualizationEnabled,
Expand All @@ -349,7 +349,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public addFailureInstance(description: string, test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IAddFailureInstancePayload = {
const payload: AddFailureInstancePayload = {
test,
step,
description,
Expand All @@ -366,7 +366,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public removeFailureInstance(test: VisualizationType, step: string, id: string): void {
const telemetry = this.telemetryFactory.forTestStepFromDetailsView(test, step);
const payload: IRemoveFailureInstancePayload = {
const payload: RemoveFailureInstancePayload = {
test,
step,
id,
Expand All @@ -388,7 +388,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator
@autobind
public editFailureInstance(description: string, test: VisualizationType, step: string, id: string): void {
const telemetry = this.telemetryFactory.fromDetailsViewNoTriggeredBy();
const payload: IEditFailureInstancePayload = {
const payload: EditFailureInstancePayload = {
test,
step,
id,
Expand All @@ -405,7 +405,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public passUnmarkedInstances(test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.fromDetailsViewNoTriggeredBy();
const payload: IToggleActionPayload = {
const payload: ToggleActionPayload = {
test,
step,
telemetry,
Expand All @@ -420,7 +420,7 @@ export class DetailsViewActionMessageCreator extends DevToolActionMessageCreator

public changeAssessmentVisualizationStateForAll(isVisualizationEnabled: boolean, test: VisualizationType, step: string): void {
const telemetry = this.telemetryFactory.fromDetailsViewNoTriggeredBy();
const payload: IChangeInstanceSelectionPayload = {
const payload: ChangeInstanceSelectionPayload = {
test: test,
step: step,
isVisualizationEnabled: isVisualizationEnabled,
Expand Down
4 changes: 2 additions & 2 deletions src/assessments/assessment-builder.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as _ from 'lodash/index';
import { IColumn } from 'office-ui-fabric-react/lib/DetailsList';
import * as React from 'react';

import { IAssessmentToggleActionPayload } from '../background/actions/action-payloads';
import { AssessmentToggleActionPayload } from '../background/actions/action-payloads';
import { InstanceIdentifierGenerator } from '../background/instance-identifier-generator';
import { RequirementComparer } from '../common/assessment/requirement-comparer';
import { IAssesssmentVisualizationConfiguration } from '../common/configs/visualization-configuration-factory';
Expand Down Expand Up @@ -85,7 +85,7 @@ export class AssessmentBuilder {
return testStepLink.renderRequirementDescriptionWithIndex();
}

private static enableTest(scanData: IScanData, payload: IAssessmentToggleActionPayload) {
private static enableTest(scanData: IScanData, payload: AssessmentToggleActionPayload) {
const scanAssessmentData = scanData as IAssessmentScanData;
scanAssessmentData.enabled = true;
scanAssessmentData.stepStatus[payload.step] = true;
Expand Down
Loading

0 comments on commit 51b3e5c

Please sign in to comment.