Deprecate aria-roledescription

microsoft · Jul 31, 2023 · ebcff53 · ebcff53
1 parent 101f15b
commit ebcff53
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/DetailsView/components/load-assessment-data-schema-provider.ts b/src/DetailsView/components/load-assessment-data-schema-provider.ts
@@ -23,7 +23,7 @@ export class LoadAssessmentDataSchemaProvider {
     private setDeprecatedRequirementProperties(schema: any) {
         const deprecatedRequirements = [
             { assessmentKey: 'automated-checks', requirementKey: 'duplicate-id' },
-            { assessmentKey: 'automated-checks', requirementKey: 'scrollable-region-focusable' },
+            { assessmentKey: 'automated-checks', requirementKey: 'aria-roledescription' },
         ];
         deprecatedRequirements.forEach(requirement => {
             if (this.getAssessments(schema)[requirement.assessmentKey] === undefined) {

diff --git a/src/tests/unit/tests/DetailsView/components/load-assessment-data-schema-provider.test.ts b/src/tests/unit/tests/DetailsView/components/load-assessment-data-schema-provider.test.ts
@@ -66,8 +66,8 @@ describe(LoadAssessmentDataSchemaProvider, () => {
                             properties:
                                 assessment.key === 'automated-checks'
                                     ? {
+                                          'aria-roledescription': stepProperties,
                                           'duplicate-id': stepProperties,
-                                          'scrollable-region-focusable': stepProperties,
                                       }
                                     : {},
                             type: ['object', 'null'],

diff --git a/src/tests/unit/tests/scanner/__snapshots__/get-rule-inclusions.test.ts.snap b/src/tests/unit/tests/scanner/__snapshots__/get-rule-inclusions.test.ts.snap
@@ -48,7 +48,8 @@ exports[`getRuleInclusions getRuleInclusions matches snapshotted list of product
     "status": "included",
   },
   "aria-roledescription": {
-    "status": "included",
+    "reason": "disabled in axe config",
+    "status": "excluded",
   },
   "aria-roles": {
     "status": "included",