fix: Can't toggle off from the ad-hoc tools menu if you've toggled on in DetailsView

[madalynrose]

Details

Two ad-hoc tools (Automated Checks and Needs Review) have the ability to view issues in DetailsView. Unfortunately, if you try to toggle either of them off in ad-hoc tools while their corresponding DetailsView list of issues is open, the DetailsView toggle will overwrite the "off" state and force it to be "on". Additionally, toggling off in DetailsView does not turn the toggle off in ad-hoc tools.

This PR keeps these toggles in sync by:

• moving the code that determines if a scan needs to be run based on state to componentDidMount instead of on render.
• triggering VisualizationActions.enableVisualization/VisualizationActions.disabledVisualization when CardSelectionActions.toggleVisualHelper is triggered, which involves:
  • making sure VisualizationActions are accessible from CardSelectionActionCreators
  • sending a VisualizationTogglePayload instead of BasePayload with the enabled state (passed in from the VisualHelperToggle's onClick)
• triggering CardSelectionActions.toggleVisualHelper when VisualizationActions.enableVisualization/VisualizationActions.disabledVisualization are triggered, which involves:
  • checking the value of payload.test and triggering needsReviewSelectionActions.toggleVisualHelper or cardSelectionActions.toggleVisualHelper if the VisualizationType matches.

Motivation

Addresses issue #6253

Context

Pull request checklist

• Addresses an existing issue: Can't toggle off from the ad-hoc panel if you've toggled on in DetailsView #6253
• Added/updated relevant unit test(s) (and ran yarn test)
• Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
• PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.