Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting issues and syntax errors in code #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fvet
Copy link
Contributor

@fvet fvet commented Nov 24, 2023

Following the recent thread on https://twitter.com/arthrvdv/status/1727729430737342791 and StefanMaron/BusinessCentral.LinterCop#352

  • Remove semicolon at end of procedures

Copy link
Collaborator

@TheDoubleH TheDoubleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@christianbraeunlich
Copy link
Contributor

Do we really want to change the archived NAV patterns in their original form?

@JeremyVyska
Copy link
Collaborator

@waldo1001 @ajkauffmann @JesperSchulz - PR has been waiting for a 3rd blessing for a lil while now?

As to 'changing the NAV patterns', which is always a valid check-in, I think that's a typo in conversion, as in NAV, procedures didn't have written lines, they were non-editable "heading" components editable via a separate UI, not plaintext. No semicolons would have been possible, so I think this is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants