Merge pull request #67 from Microsoft/users/lukillgo/sendbundle

#871016 Mobile: Apple App Store asks for bundle ID TestFlight
microsoft · Apr 7, 2017 · 2808b3d · 2808b3d
2 parents f98eadd + 7abac0d
commit 2808b3d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Tasks/app-store-release/Tests/L0.ts b/Tasks/app-store-release/Tests/L0.ts
@@ -231,7 +231,7 @@ describe('app-store-release L0 Suite', function () {
         let tr: ttm.MockTestRunner = new ttm.MockTestRunner(tp);
 
         tr.run();
-        assert(tr.ran('fastlane pilot upload -u creds-username -i mypackage.ipa -q teamId'), 'fastlane pilot upload with teamId should have been run.');
+        assert(tr.ran('fastlane pilot upload -u creds-username -i mypackage.ipa -q teamId -a com.microsoft.test.appId'), 'fastlane pilot upload with teamId should have been run.');
         assert(tr.invokedToolCount === 3, 'should have run gem install, gem update and fastlane pilot.');
         assert(tr.stderr.length === 0, 'should not have written to stderr');
         assert(tr.succeeded, 'task should have succeeded');

diff --git a/Tasks/app-store-release/Tests/L0TestFlightTeamId.ts b/Tasks/app-store-release/Tests/L0TestFlightTeamId.ts
@@ -53,7 +53,7 @@ let myAnswers: string = `{
             "code": 0,
             "stdout": "1 gem installed"
         },
-        "fastlane pilot upload -u creds-username -i mypackage.ipa -q teamId": {
+        "fastlane pilot upload -u creds-username -i mypackage.ipa -q teamId -a com.microsoft.test.appId": {
             "code": 0,
             "stdout": "consider it uploaded!"
         }

diff --git a/Tasks/app-store-release/app-store-release.ts b/Tasks/app-store-release/app-store-release.ts
@@ -169,13 +169,15 @@ async function run() {
         if (releaseTrack === 'TestFlight') {
             // Run pilot (via fastlane) to upload to testflight
             let pilotCommand: ToolRunner = tl.tool('fastlane');
+            let bundleIdentifier: string = tl.getInput('appIdentifier', false);
             pilotCommand.arg(['pilot', 'upload', '-u', credentials.username, '-i', ipaPath]);
             let usingReleaseNotes: boolean = isValidFilePath(releaseNotes);
             if (usingReleaseNotes) {
                 pilotCommand.arg(['--changelog', fs.readFileSync(releaseNotes).toString()]);
             }
             pilotCommand.argIf(teamId, ['-q', teamId]);
             pilotCommand.argIf(teamName, ['-r', teamName]);
+            pilotCommand.argIf(bundleIdentifier, ['-a', bundleIdentifier]);
             pilotCommand.argIf(shouldSkipSubmission, ['--skip_submission', 'true']);
             pilotCommand.argIf(shouldSkipWaitingForProcessing, ['--skip_waiting_for_build_processing', 'true']);