Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persona component #571

Merged
merged 15 commits into from
Sep 26, 2023
Merged

Persona component #571

merged 15 commits into from
Sep 26, 2023

Conversation

ollips
Copy link
Contributor

@ollips ollips commented Sep 5, 2023 •
edited
Loading

Task: task-889937

Link: preview

Adding persona component.

Testing

  1. Review code
  2. Review doc page

@ollips ollips requested a review from a team as a code owner September 5, 2023 23:35
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9041118

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@microsoft/atlas-css Minor
@microsoft/atlas-site Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ollips and others added 3 commits September 13, 2023 11:27
@ollips @homing1
Typo fix
60aa27a 
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
@ollips
Updating sizes, swithcing to t-shirt pattern naming
c38d99f
@ollips
Copy adjustments
8f87bc4
ollips and others added 3 commits September 18, 2023 15:55
@ollips
Addressing comments
5ac249e
@ollips @homing1
Updating copy
3c83260 
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
@ollips
More copy updates
d68b2c0
@ollips ollips requested review from homing1 and wibjorn September 18, 2023 23:52
@ollips ollips requested a review from BenDMyers September 19, 2023 23:21
ollips and others added 2 commits September 25, 2023 12:24
@ollips @wibjorn
Copy update
9e211ee 
Co-authored-by: Will Bjorn <30843002+wibjorn@users.noreply.github.com>
@ollips
Removing initials option; updating sizes
b9cd79c
@ollips ollips requested a review from wibjorn September 25, 2023 22:14
@ollips ollips requested a review from wibjorn September 25, 2023 23:03
BenDMyers
BenDMyers previously approved these changes Sep 26, 2023
View reviewed changes
@ollips ollips requested review from BenDMyers and wibjorn September 26, 2023 19:23
wibjorn
wibjorn previously approved these changes Sep 26, 2023
View reviewed changes
BenDMyers
BenDMyers previously approved these changes Sep 26, 2023
View reviewed changes
@ollips ollips dismissed stale reviews from BenDMyers and wibjorn via 9041118 September 26, 2023 21:36
@ollips ollips merged commit beef07a into main Sep 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wibjorn wibjorn wibjorn approved these changes

@BenDMyers BenDMyers BenDMyers approved these changes

@homing1 homing1 Awaiting requested review from homing1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ollips @BenDMyers @wibjorn @homing1