Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two sidecar layouts to layout component #586

Merged
merged 20 commits into from
Nov 29, 2023
Merged

Conversation

wibjorn
Copy link
Contributor

@wibjorn wibjorn commented Nov 28, 2023

Task: task-925514
Task: task-925513

Link: preview-586
Page specific link: https://design.learn.microsoft.com/pulls/586/components/layout.html

This pull request adds a third possible layout to the .layout component. See documentation page for details. Also fixes a mobile navigation issue introduced late in the review process for #582

Testing

  1. Visit documentation page.
  2. Select "Show container labels" button
  3. Select "Sidecar left" and "Sidecar right" from the layout buttons.
  4. Read through code.

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@wibjorn wibjorn requested a review from a team as a code owner November 28, 2023 22:49
Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 4c57a4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@microsoft/atlas-site Minor
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wibjorn wibjorn changed the title Wbb/layout sidebars Add two sidecar layouts to layout component Nov 28, 2023
Co-authored-by: Ben Myers <benmyers@microsoft.com>
disimmon
disimmon previously approved these changes Nov 29, 2023
site/src/components/layout.md Outdated Show resolved Hide resolved
site/src/components/layout.md Show resolved Hide resolved
site/src/components/layout.md Show resolved Hide resolved
wibjorn and others added 2 commits November 29, 2023 14:12
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
@wibjorn wibjorn merged commit 46e987b into main Nov 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants