-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two sidecar layouts to layout component #586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c57a4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wibjorn
changed the title
Wbb/layout sidebars
Add two sidecar layouts to layout component
Nov 28, 2023
disimmon
reviewed
Nov 28, 2023
BenDMyers
reviewed
Nov 29, 2023
Co-authored-by: Ben Myers <benmyers@microsoft.com>
BenDMyers
reviewed
Nov 29, 2023
disimmon
previously approved these changes
Nov 29, 2023
homing1
reviewed
Nov 29, 2023
Co-authored-by: Ming Ho <94572161+homing1@users.noreply.github.com>
homing1
approved these changes
Nov 29, 2023
disimmon
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: task-925514
Task: task-925513
Link: preview-586
Page specific link: https://design.learn.microsoft.com/pulls/586/components/layout.html
This pull request adds a third possible layout to the
.layout
component. See documentation page for details. Also fixes a mobile navigation issue introduced late in the review process for #582Testing
Contributor checklist