Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update line-height-normal and white-space #690

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

homing1
Copy link
Contributor

@homing1 homing1 commented Oct 3, 2024

Task: task-[work-item-number]

Link: preview

This PR adds !important to line-height-normal and white-space-* atomics.

Testing

  1. Step one
  2. Step two
    Expected result:

Additional information

[Optional]

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@homing1 homing1 requested a review from a team as a code owner October 3, 2024 19:37
Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 568946e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ollips
ollips previously approved these changes Oct 4, 2024
ellynliu
ellynliu previously approved these changes Oct 4, 2024
@homing1 homing1 dismissed stale reviews from ellynliu and ollips via 20e44e5 October 4, 2024 19:50
ellynliu
ellynliu previously approved these changes Oct 4, 2024
'@microsoft/atlas-css': patch
---

Add !important to line-height-normal and white-space atomics.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: !important flag.

@homing1 homing1 merged commit 0f89f52 into main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants