Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking site header buttons's underline on hover #715

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ollips
Copy link
Contributor

@ollips ollips commented Nov 4, 2024

Task: task-1010346

Link: preview

Adding rules to disable underline in hover state.

Testing

  1. Visit any page.
  2. Make sure brand link on hover state doesn't have double underline
  3. Review code

Contributor checklist

  • Did you update the description of this pull request with a review link and test steps?
  • Did you submit a changeset? Changesets are required for all code changes.
  • Does your pull request implement complex UI logic (js/ts)? Consider adding an integration test to test your user flow.
  • Does your pull request add a new page to the documentation site? Add your new page for automated accessibility testing in /integration/tests/accessibility.

@ollips ollips requested a review from a team as a code owner November 4, 2024 22:37
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 6093fff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@microsoft/atlas-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ollips ollips merged commit 920130e into main Nov 5, 2024
6 checks passed
@ollips ollips deleted the olga/site-header-buttons-hover branch November 5, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants