[Issue]: Fix stability of git pre-commit format checks.

[afourney]

Can we please do something to improve the stability of the pre-commit formatting checks?

I'll pull a fresh copy of the repo, edit one line in one file, and end up failing some pre-commit check in an unrelated part of the code. Sometimes there are even errors in files that I haven't edited, causing the commit to succeed, but the server-side check to fail. Easily half my commits are fixes to these kinds of formatting checks.

I have no idea what is causing the instability. But it is maddening.

Also, pro-tip:

pre-commit run --all-files

Steps to reproduce

No response

Screenshots and logs

No response

Additional Information

No response

[gagb]

Are you having these issues in code spaces?

[afourney]

No. My local Ubuntu LTS dev environment.

(Autogenbench I don't think runs in code spaces due to special docker requirement)

[jackgerrits]

It's weird because the pre-commit black version is already pinned

autogen/.pre-commit-config.yaml

Line 26 in 1ab2354

rev: 23.3.0

[jackgerrits]

This repros in a fresh codespace

[afourney]

These latest issues I think are related to the notebooks. Notebooks use a different strategy for running black.

[sonichi]

@davorrunje or @bitnom do you have a clue?

[afourney]

FWIF, I'm still experiencing this instability with some of my commits.

I've been working around it by running pre-commit on all files, then staging the changes, then uninstalling pre-commit before committing (other they just change back and forth in a loop)

[davorrunje]

Sorry for the late reply, I am just catching up with the backlog. I always use

pre-commit run --all-files

just to be on the safe side.

@sonichi With respect to notebooks, I added black to notebooks using nbqa and never had any issue with it before. Is this still happening?

[ekzhu]

@afourney Is this already fixed?

[afourney]

It has not happened to me in a while. Perhaps safe to close.

[ekzhu]

I love closing issues