Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PR: Add gitignore and improve template detection #1482

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Jan 31, 2024

Why are these changes needed?

I am trying to address #1478 but we need to make some fixes to make it easy to collaborate on the AutoGenBench code.

This PR

  • adds a gitignore to ignore Dowloads and Tasks in scenarios and Results in cwd
  • generalizes init_tasks.py to detect all templates present in Templates

I will progressively make more comprehensive PR for long context management after this PR merge goes well, e.g., via a new template that uses hooks/capabilities

Why are so many folders using capitalized names??

Related issue number

#1478

Checks

@gagb gagb added the gaia PRs or issues related to GAIA (enabling measurement, or improving performance) label Jan 31, 2024
@gagb gagb requested a review from afourney January 31, 2024 02:56
@gagb gagb marked this pull request as ready for review January 31, 2024 02:56
@gagb
Copy link
Collaborator Author

gagb commented Jan 31, 2024

I will need help to resolve the formatting issue on this branch... Presumably because this branch is using a different pre-commit than what GH uses? @afourney might wanna update your dev branch to latest.

@afourney
Copy link
Member

afourney commented Jan 31, 2024

@gagb If you can figure out why this branch has pre-commit issues, you will be my savior and I will forever be in your debt. This is exactly why I filed #1418. It should be up to date with main as of this morning.

I like where this commit is going. I will review and probably merge it tonight after testing.

As for folder naming, I opened an issue to discuss this as far back as December #976. It was only recently that it seems to have ruffled any feathers (see #1424). There's an issue to possibly address it, but it's actually quite a lot of work. Like a lot of work. None of these are python modules, so I didn't apply python module naming rules (which I dislike). Where I am building python modules (e.g., the autogenbench sub folder), casing follows that convention.

@afourney afourney merged commit c0be5e5 into microsoft:autogenbench Jan 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gaia PRs or issues related to GAIA (enabling measurement, or improving performance)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants