Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: User interface views need sender returned in new "process_message_before_send" hook #1788

Closed
radman-x opened this issue Feb 26, 2024 · 2 comments · Fixed by #1799
Closed
Assignees
Labels
good first issue Good for newcomers

Comments

@radman-x
Copy link
Collaborator

Describe the bug

User interfaces for chat-like experience need to know what the sender is in the new "process_message_before_send" hook (PR #1783). Having the recipient is good but not enough. This is a very simple fix -- just pass "self" as the sender in ConversableAgent._process_message_before_send().

Steps to reproduce

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

@radman-x radman-x added the bug label Feb 26, 2024
@sonichi sonichi added the good first issue Good for newcomers label Feb 26, 2024
@sonichi
Copy link
Contributor

sonichi commented Feb 26, 2024

Thanks. Adding sender in the hook is good. Would you like to make a PR?

@RohitRathore1
Copy link
Contributor

Thanks. Adding sender in the hook is good. Would you like to make a PR?

@sonichi I would like to open the PR against this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants