Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook-list are updated to accept a sender argument #1799

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

RohitRathore1
Copy link
Contributor

@RohitRathore1 RohitRathore1 commented Feb 27, 2024

Why are these changes needed?

this change ensures that when it invoke _process_message_before_send, the hooks executed within will have access to the sender, recipient, message, and silent flag.

Related issue number

Closes #1788

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.02%. Comparing base (d797d26) to head (7372b85).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1799       +/-   ##
===========================================
+ Coverage   37.05%   48.02%   +10.97%     
===========================================
  Files          62       62               
  Lines        6499     6528       +29     
  Branches     1438     1571      +133     
===========================================
+ Hits         2408     3135      +727     
+ Misses       3898     3144      -754     
- Partials      193      249       +56     
Flag Coverage Δ
unittests 47.94% <ø> (+10.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohitRathore1 RohitRathore1 marked this pull request as draft February 27, 2024 06:25
@RohitRathore1 RohitRathore1 marked this pull request as draft February 27, 2024 06:25
@radman-x
Copy link
Collaborator

@RohitRathore1 This looks good, thnx.

@RohitRathore1
Copy link
Contributor Author

@RohitRathore1 This looks good, thnx.

Thanks, I need to make changes in test. I will do in few hours.

Copy link
Collaborator

@radman-x radman-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sonichi sonichi added this pull request to the merge queue Feb 28, 2024
Merged via the queue into microsoft:main with commit dc89147 Feb 28, 2024
46 of 57 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* hook-list are updated to accept a sender argument

* Update the hook function Signature & add assertions for Sender
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: User interface views need sender returned in new "process_message_before_send" hook
5 participants