-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hook-list are updated to accept a sender argument #1799
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
===========================================
+ Coverage 37.05% 48.02% +10.97%
===========================================
Files 62 62
Lines 6499 6528 +29
Branches 1438 1571 +133
===========================================
+ Hits 2408 3135 +727
+ Misses 3898 3144 -754
- Partials 193 249 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@RohitRathore1 This looks good, thnx. |
Thanks, I need to make changes in test. I will do in few hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
* hook-list are updated to accept a sender argument * Update the hook function Signature & add assertions for Sender
Why are these changes needed?
this change ensures that when it invoke
_process_message_before_send
, the hooks executed within will have access to the sender, recipient, message, and silent flag.Related issue number
Closes #1788
Checks