Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename seed to cache_seed #599

Closed
2 of 3 tasks
sonichi opened this issue Nov 8, 2023 · 4 comments
Closed
2 of 3 tasks

rename seed to cache_seed #599

sonichi opened this issue Nov 8, 2023 · 4 comments
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Comments

@sonichi
Copy link
Contributor

sonichi commented Nov 8, 2023

openai introduces a new param in chat completion api:

  • seed: This feature is in Beta. If specified, our system will make a best effort to
    sample deterministically, such that repeated requests with the same seed and
    parameters should return the same result. Determinism is not guaranteed, and you
    should refer to the system_fingerprint response parameter to monitor changes
    in the backend.

"Determinism is not guaranteed" - that's a reason to keep the seed in autogen, but rename it to cache_seed. Then, we'll be able to support both openai seed and autogen seed.

Tasks

@sonichi sonichi added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 8, 2023
@jackgerrits
Copy link
Member

@sonichi can this be closed now?

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 13, 2024

Yes.

@ekzhu ekzhu closed this as completed Feb 13, 2024
@sonichi
Copy link
Contributor Author

sonichi commented Feb 13, 2024

mathchat still depends on the old version of pyautogen. @kevin666aa may need to decide what to do with it.

@yiranwu0
Copy link
Collaborator

mathchat still depends on the old version of pyautogen. @kevin666aa may need to decide what to do with it.

Got it. I will go over MathChat and propose a solution later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants