-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets the umask before executing the task in Docker. #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to confirm whether this is intended for use of pyautogen<0.2 only, and if so, the README needs to state that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 34.04% 28.70% -5.35%
==========================================
Files 25 27 +2
Lines 3005 3383 +378
Branches 668 760 +92
==========================================
- Hits 1023 971 -52
- Misses 1906 2341 +435
+ Partials 76 71 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Sets the umask before executing the task in Docker. * Added version backward compatibility for disabling cache and setting timeouts.
Why are these changes needed?
When code is run in Docker, the output files are owned by root, and may not be manageable by the user who is running Autogen. This PR sets the umask to 000 so that files created in the Testbed's docker environment are world-writable, and can be managed.
Related issue number
Closes #592
Checks