-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional docs in retrieval agent if required #1028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor:formatter
feat:updated position
Update dbutils.py
added feature to add docs in retrieve
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 20, 2023 07:00
— with
GitHub Actions
Failure
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
===========================================
+ Coverage 30.27% 53.76% +23.48%
===========================================
Files 30 30
Lines 3980 3988 +8
Branches 897 948 +51
===========================================
+ Hits 1205 2144 +939
+ Misses 2696 1648 -1048
- Partials 79 196 +117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi @victordibia @elecnix @halr9000 @joshuavial please review it |
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:14
— with
GitHub Actions
Failure
feat:fixed pre commit issue
ShobhitVishnoi30
temporarily deployed
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Inactive
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Failure
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Failure
ShobhitVishnoi30
temporarily deployed
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Inactive
ShobhitVishnoi30
had a problem deploying
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Failure
ShobhitVishnoi30
temporarily deployed
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Inactive
ShobhitVishnoi30
temporarily deployed
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Inactive
ShobhitVishnoi30
temporarily deployed
to
openai1
December 21, 2023 10:50
— with
GitHub Actions
Inactive
qingyun-wu
approved these changes
Dec 25, 2023
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Update conversable_agent.py * Add files via upload * Delete notebook/Async_human_input.ipynb * Add files via upload * refactor:formatter * feat:updated position * Update dbutils.py * added feature to add docs in retrieve * Update dbutils.py * Update retrieve_user_proxy_agent.py * Update retrieve_utils.py * Update qdrant_retrieve_user_proxy_agent.py * Update qdrant_retrieve_user_proxy_agent.py * feat:fixed pre commit issue --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com> Co-authored-by: svrapidinnovation <sv@rapidinnovation.dev> Co-authored-by: Li Jiang <bnujli@gmail.com> Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If you have existing documents in the retriever agent instance, and you want to add more documents using the current implementation, it currently replaces the existing ones because the document IDs always start with "doc_0."
To address this, we've updated the functionality to allow assigning different IDs if the user wishes to add additional documents.I've incorporated an "extra_docs" configuration within the retrieval settings. When set to true, the system will assign IDs to the chunks starting from "length+i" when inserting the document into the Chroma database. This modification ensures that existing documents are not replaced, allowing for the addition of more documents to the same collection.
Related issue number
issue
Checks