Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbqa adedd to pre-commit, added black and ruff for notebooks #1171

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

Ruff and black are being run on python files by pre-commit, but not on notebooks. Nbqa can be used to perform the same on the notebooks as well. This PR adds nbqa command to pre-commit.

Related issue number

Closes #1170

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3680197) 31.92% compared to head (16c79a1) 41.64%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   31.92%   41.64%   +9.71%     
==========================================
  Files          29       29              
  Lines        4097     4097              
  Branches      955     1006      +51     
==========================================
+ Hits         1308     1706     +398     
+ Misses       2695     2219     -476     
- Partials       94      172      +78     
Flag Coverage Δ
unittests 41.54% <ø> (+9.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 1c4ae3d Jan 8, 2024
22 checks passed
@sonichi sonichi deleted the nbqa branch January 8, 2024 03:52
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…ft#1171)

* nbqa adedd to pre-commit, added black and ruff for notebooks

* polishing

* polishing

* polishing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add black and ruff formatting to notebooks
4 participants