[AutoGen Studio] Fix the new workflow process

[shhdgit]

Why are these changes needed?

Because the new workflow state is set to null, we are unable to add a new workflow again after editing or closing the workflow modal.

Before:

Screen.Recording.2024-01-09.at.16.16.08.mov

After:

Screen.Recording.2024-01-09.at.16.17.47.mov

Checks

• I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[shhdgit]

@microsoft-github-policy-service agree

[victordibia]

Thanks for finding this bug and suggesting a fix.
This PR makes changes to the convention used across multiple files (e.g., setWorkflow being renamed to saveWorflow).

Please consider limiting the change to removing setWorkflow(null). We can create a separate PR towards a general style refactor.

[shhdgit]

Thanks for finding this bug and suggesting a fix. This PR makes changes to the convention used across multiple files (e.g., setWorkflow being renamed to saveWorflow).

Please consider limiting the change to removing setWorkflow(null). We can create a separate PR towards a general style refactor.

Thank you for your advice! The WorkflowModal seems like an internal implementation.
Do you mean something like the code snippet below to remove the setWorkflow(null) for "new workflow" only?

  const defaultConfig = sampleWorkflowConfig();
  const [newWorkflow] = React.useState<IFlowConfig | null>(defaultConfig);
  
  ...
  
  const WorkflowModal = ({
    workflow,
    setWorkflow,
    showWorkflowModal,
    setShowWorkflowModal,
    handler,
  }: {
    workflow: IFlowConfig | null;
    setWorkflow?: (workflow: IFlowConfig | null) => void;
    showWorkflowModal: boolean;
    setShowWorkflowModal: (show: boolean) => void;
    handler?: (workflow: IFlowConfig) => void;
  }) => {
  
  ...
  
      <Modal
        title={
          <>
            Workflow Specification{" "}
            <span className="text-accent font-normal">
              {localWorkflow?.name}
            </span>{" "}
          </>
        }
        width={800}
        open={showWorkflowModal}
        onOk={() => {
          setShowWorkflowModal(false);
          if (handler) {
            handler(localWorkflow as IFlowConfig);
          }
        }}
        onCancel={() => {
          setShowWorkflowModal(false);
          setWorkflow?.(null);
        }}
      >
      
  ...
  
  return (
    <div className="  ">
      <WorkflowModal
        workflow={selectedWorkflow}
        setWorkflow={setSelectedWorkflow}
        showWorkflowModal={showWorkflowModal}
        setShowWorkflowModal={setShowWorkflowModal}
        handler={(workflow: IFlowConfig) => {
          saveWorkFlow(workflow);
          setShowWorkflowModal(false);
        }}
      />

      <WorkflowModal
        workflow={newWorkflow}
        showWorkflowModal={showNewWorkflowModal}
        setShowWorkflowModal={setShowNewWorkflowModal}
        handler={(workflow: IFlowConfig) => {
          saveWorkFlow(workflow);
          setShowNewWorkflowModal(false);
        }}
      />
  ...

[shhdgit]

@victordibia PTAL, thanks!

[victordibia]

Thanks

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (563b1bb) 32.08% compared to head (8f4bb9d) 32.08%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1181   +/-   ##
=======================================
  Coverage   32.08%   32.08%           
=======================================
  Files          32       32           
  Lines        4394     4394           
  Branches     1025     1025           
=======================================
  Hits         1410     1410           
  Misses       2867     2867           
  Partials      117      117           

Flag	Coverage Δ
unittests	32.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.