Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev container for AutoGen Studio #1241

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Add dev container for AutoGen Studio #1241

merged 4 commits into from
Jan 19, 2024

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Jan 14, 2024

Solution:
Create a subdirectory called .devcontainer/studio with correct Dockerfile and devcontainer.json.
I reused the Dockerfile from .devcontainer and modified the devcontainer.json to follow instructions from AutoGen Studios README.

I tested this container with GitHub Codespaces.

Why are these changes needed?

We need to add a dev container for AutoGen Studio

Related issue number

#1224

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bde2fc9) 32.10% compared to head (775226a) 32.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   32.10%   32.10%           
=======================================
  Files          32       32           
  Lines        4392     4392           
  Branches     1024     1024           
=======================================
  Hits         1410     1410           
  Misses       2866     2866           
  Partials      116      116           
Flag Coverage Δ
unittests 32.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb marked this pull request as ready for review January 14, 2024 05:21
@gagb gagb requested a review from victordibia January 14, 2024 05:22
@gagb
Copy link
Collaborator Author

gagb commented Jan 14, 2024

@victordibia I need your help to add a relevant reviewer to this PR.

@gagb gagb changed the title Create studio subfolder in devcontainer Add dev container for AutoGen Studio Jan 14, 2024
@gagb gagb added the ui/deploy label Jan 15, 2024
@sonichi
Copy link
Contributor

sonichi commented Jan 17, 2024

How do we use it? If I open a GitHub codespace I don't get to choose which Dockerfile to use, do I?

@gagb
Copy link
Collaborator Author

gagb commented Jan 17, 2024

How do we use it? If I open a GitHub codespace I don't get to choose which Dockerfile to use, do I?

Use the "new with options"

image

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirm I tested this and it works correctly.
I was able to launch a dev container on GH codespaces and autogenstudio was available on the terminal.

@sonichi
Copy link
Contributor

sonichi commented Jan 18, 2024

How do we use it? If I open a GitHub codespace I don't get to choose which Dockerfile to use, do I?

Use the "new with options"

image

Thanks. Could you add this info to documentation?

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that documentation is missing. I am fine merging this PR. We could add documentation in a separate PR.

@qingyun-wu qingyun-wu added this pull request to the merge queue Jan 18, 2024
@gagb
Copy link
Collaborator Author

gagb commented Jan 18, 2024

LGTM except that documentation is missing. I am fine merging this PR. We could add documentation in a separate PR.

Ty, working on that issue

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 18, 2024
@qingyun-wu qingyun-wu added this pull request to the merge queue Jan 18, 2024
Merged via the queue into microsoft:main with commit 9729610 Jan 19, 2024
16 checks passed
@gagb gagb deleted the i1224 branch January 26, 2024 23:48
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* Create studio subfolder in devcontainer

* Update to follow readme instructions
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Create studio subfolder in devcontainer

* Update to follow readme instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants