Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test for function call in groupchat #1252

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Improve test for function call in groupchat #1252

merged 2 commits into from
Jan 14, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Jan 14, 2024

Why are these changes needed?

The test #1243 misses await for the async test. This PR takes suggestions from @davorrunje to fix it and add check that the functions are indeed called.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b2955d) 31.60% compared to head (49430a1) 41.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   31.60%   41.26%   +9.66%     
==========================================
  Files          32       32              
  Lines        4389     4389              
  Branches     1024     1079      +55     
==========================================
+ Hits         1387     1811     +424     
+ Misses       2892     2401     -491     
- Partials      110      177      +67     
Flag Coverage Δ
unittests 41.19% <ø> (+9.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Jan 14, 2024
Merged via the queue into main with commit 1565795 Jan 14, 2024
22 checks passed
@sonichi sonichi deleted the p1243 branch January 14, 2024 23:47
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants