Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression agent #131
Add compression agent #131
Changes from all commits
791019c
2ff2263
400943e
556b80a
e4c4b91
a9ce4c7
a81341d
f872a6f
1938d75
0d4d7dd
e95797f
cb3df56
f6ebf11
bf88321
e09464c
0e9168a
1a63430
4109f58
a60dd8e
bbc90e5
19551d5
26c8cf7
5e826e9
ffb314c
ec9ff7f
f64a074
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I removed the two lines here (need to confirm):
Why we can delete this:
The two lines deleted is in every
generate_<>_reply
function. So when both messages and sender are passed to a subsequentgenerate_<>_reply
, it will perform the same logic.Why needed for compression: Compression will modify
self._oai_messages
, and it is expected thatgenerate_oai_reply
will use the updated messages fromself._oai_messages
. With the two lines, the messages will not be None and the updatedself._oai_messages
will not be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both justifications are not clear to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option is to only remove this when
compress_config
is provided. This ensures the original logic is unchanged in the default seting