Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websockets for streaming to a frontend #1414

Closed
wants to merge 0 commits into from
Closed

Add websockets for streaming to a frontend #1414

wants to merge 0 commits into from

Conversation

Tylersuard
Copy link
Collaborator

@Tylersuard Tylersuard commented Jan 26, 2024

@sonichi

Why are these changes needed?

If a user wants to have a frontend for an autogen-based chat, websockets will be required to stream information out of autogen. These changes will allow the user to stream content from a conversation to any address they choose. See https://websockets.readthedocs.io/en/stable/

Related issue number

#1199 , #1143 , #217 , #394

Checks

@Tylersuard
Copy link
Collaborator Author

Tylersuard commented Jan 26, 2024

@sonichi the code formatting test is failing on scripts that I didn't write. Also, I have no idea why adding websockets would interfere with the WebSurfer tests, but it's happening with other PR's as well.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (015070b) 33.12% compared to head (76c8770) 4.17%.

Files Patch % Lines
autogen/agentchat/conversable_agent.py 0.00% 6 Missing ⚠️
autogen/oai/client.py 33.33% 4 Missing ⚠️
autogen/streaming_utils.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1414       +/-   ##
==========================================
- Coverage   33.12%   4.17%   -28.95%     
==========================================
  Files          42      41        -1     
  Lines        5051    5054        +3     
  Branches     1157    1225       +68     
==========================================
- Hits         1673     211     -1462     
- Misses       3250    4833     +1583     
+ Partials      128      10      -118     
Flag Coverage Δ
unittests 4.17% <12.50%> (-28.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davorrunje
Copy link
Collaborator

davorrunje commented Feb 1, 2024

@Tylersuard do you want me to look into failing tests?

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 4, 2024

looks like we might be getting a dangling PR here.

@davorrunje would you be interested in taking over this?

@Tylersuard
Copy link
Collaborator Author

Tylersuard commented Feb 4, 2024 via email

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 4, 2024

@Tylersuard you can see my comments in the code. There is a recent change to the oai/client.py that conflicts with the changes you made. So there is work in redoing your changes but in the new oai/client.py. There are a couple minor comments I have that could be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants