Fix for bugs appeared when using function calls with clear history functionality #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
===========================================
+ Coverage 35.69% 54.64% +18.95%
===========================================
Files 63 63
Lines 6625 6637 +12
Branches 1454 1581 +127
===========================================
+ Hits 2365 3627 +1262
+ Misses 4067 2713 -1354
- Partials 193 297 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Probably need to write test for that improvements, but don't know how to set up agent to call function as default message; any suggestions will be appriciated. |
sonichi
requested review from
ekzhu,
davorrunje and
AaronWard
and removed request for
davorrunje
|
@sonichi Is it ok now? Can we merge? |
sonichi
approved these changes
Mar 2, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…nctionality (microsoft#1531) * resolved errors happening when using function calling and clear history * checking in nr_of_messages_to_preserve were provided * code formatting * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * test added, dict signature improved * Test updated Co-authored-by: Chi Wang <wang.chi@microsoft.com> * test improved * test improved * comment about preserving additional message added * commentary about clear history called in tool response improved * created test for clear hisotry called from tool response * code formatting * added 'USER INTERRUPTED' as internal content of tool response * added separate vatiable 'nr_messages_to_preserve_internal' --------- Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When started to use manual history feature of GroupChat and agent have made function calls, I found next problems:
To sum up, all bugs were fixed.
Checks