Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SocietyOfMind agent to work with function calling and tools. #1569

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

afourney
Copy link
Member

@afourney afourney commented Feb 6, 2024

Why are these changes needed?

Resolves #1553, and adds tests to ensure it doesn't break again.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3e33a2c) 35.28% compared to head (7ac93b9) 65.30%.

Files Patch % Lines
autogen/agentchat/contrib/society_of_mind_agent.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1569       +/-   ##
===========================================
+ Coverage   35.28%   65.30%   +30.02%     
===========================================
  Files          44       44               
  Lines        5311     5324       +13     
  Branches     1231     1305       +74     
===========================================
+ Hits         1874     3477     +1603     
+ Misses       3283     1515     -1768     
- Partials      154      332      +178     
Flag Coverage Δ
unittests 65.27% <0.00%> (+29.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 53e6d28 Feb 7, 2024
55 of 56 checks passed
@afourney afourney deleted the i1553 branch February 7, 2024 02:30
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…icrosoft#1569)

* Allow SocietyOfMind agent to work with function calling and tools.

* Correctly skip OpenAI tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable use function calling with society_of_mind_agent
3 participants