Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Fix on the Google Colab Link #1571

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

joshkyh
Copy link
Collaborator

@joshkyh joshkyh commented Feb 6, 2024

Adding gagb for a notebook correction.

Why are these changes needed?

The colab button is opening the wrong notebook.

Related issue number

Checks

@joshkyh joshkyh requested a review from gagb February 6, 2024 23:56
@joshkyh joshkyh self-assigned this Feb 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e33a2c) 35.28% compared to head (5628177) 35.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1571   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files          44       44           
  Lines        5311     5311           
  Branches     1231     1231           
=======================================
  Hits         1874     1874           
  Misses       3283     3283           
  Partials      154      154           
Flag Coverage Δ
unittests 35.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshkyh joshkyh marked this pull request as ready for review February 6, 2024 23:59
@joshkyh
Copy link
Collaborator Author

joshkyh commented Feb 7, 2024

That is awesomely fast @gagb! Thanks!

@gagb
Copy link
Collaborator

gagb commented Feb 7, 2024

Thanks for spotting the error!

@qingyun-wu qingyun-wu added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 6ab0487 Feb 7, 2024
22 checks passed
@joshkyh joshkyh deleted the quick-fix-google-colab-agentchat-langchain branch February 7, 2024 03:12
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants