Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base container for website #1584

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Update base container for website #1584

merged 2 commits into from
Feb 8, 2024

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Feb 7, 2024

Why are these changes needed?

Related issue number

#1502

Checks

@gagb
Copy link
Collaborator Author

gagb commented Feb 7, 2024

@jackgerrits @victordibia -- I have made the fixes but the documentation issue is still there. But its not blocking me so I haven't addressed that here.

@gagb gagb marked this pull request as ready for review February 7, 2024 23:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d675489) 35.23% compared to head (e56b312) 35.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   35.23%   35.23%           
=======================================
  Files          44       44           
  Lines        5327     5327           
  Branches     1236     1236           
=======================================
  Hits         1877     1877           
  Misses       3296     3296           
  Partials      154      154           
Flag Coverage Δ
unittests 35.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagb gagb requested a review from sonichi February 8, 2024 00:20
@sonichi sonichi added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 68337b9 Feb 8, 2024
22 checks passed
@sonichi sonichi deleted the i1502 branch February 11, 2024 02:17
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add dependencies for website

* Add a shell script to build the website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants