Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy PR for Long Context Capability 1513 #1591

Merged
merged 31 commits into from
Feb 8, 2024
Merged

Proxy PR for Long Context Capability 1513 #1591

merged 31 commits into from
Feb 8, 2024

Conversation

gagb
Copy link
Collaborator

@gagb gagb commented Feb 8, 2024

Why are these changes needed?

This is a new PR in lieu of #1513 because that one was made from fork and @sonichi wanted it to be autogen.
So I created a new branch in microsoft/autogen, merged my fork into, and created a new PR

Related issue number

#1513

Checks

@sonichi
Copy link
Contributor

sonichi commented Feb 8, 2024

You can change the workflow back after the tests passed. Thanks.

It passed. I updated from main before trying to change to pull_request_target. Now it's again waiting for approval. Should I have not done that. I'd love to understand what's going on here in the next SCRUM.

You can ask authors of other contrib-openai tests. They've all gone through this.

@rickyloynd-microsoft
Copy link
Contributor

You can change the workflow back after the tests passed. Thanks.

It passed. I updated from main before trying to change to pull_request_target. Now it's again waiting for approval. Should I have not done that. I'd love to understand what's going on here in the next SCRUM.

You can ask authors of other contrib-openai tests. They've all gone through this.

I've gone through this process, but I don't remember the details. We should really document it in a prominent place.

@sonichi
Copy link
Contributor

sonichi commented Feb 8, 2024

You can change the workflow back after the tests passed. Thanks.

It passed. I updated from main before trying to change to pull_request_target. Now it's again waiting for approval. Should I have not done that. I'd love to understand what's going on here in the next SCRUM.

You can ask authors of other contrib-openai tests. They've all gone through this.

I've gone through this process, but I don't remember the details. We should really document it in a prominent place.

Or find a better solution.

@sonichi sonichi added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 47d6c75 Feb 8, 2024
49 of 59 checks passed
@gagb
Copy link
Collaborator Author

gagb commented Feb 8, 2024

relevant to #1478

@gagb gagb deleted the long_context branch February 8, 2024 20:56
@gagb gagb mentioned this pull request Mar 18, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add new capability to handle long context

* Make print conditional

* Remove superfluous comment

* Fix msg order

* Allow user to specify max_tokens

* Add ability to specify max_tokens per message; improve name

* Improve doc and readability

* Add tests

* Improve documentation and add tests per Erik and Chi's feedback

* Update notebook

* Update doc string of add to agents

* Improve doc string

* improve notebook

* Update github workflows for context handling

* Update docstring

* update notebook to use raw config list.

* Update contrib-openai.yml remove _target

* Fix code formatting

* Fix workflow file

* Update .github/workflows/contrib-openai.yml

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants