Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid access private variable #1592

Merged
merged 2 commits into from
Feb 8, 2024
Merged

avoid access private variable #1592

merged 2 commits into from
Feb 8, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 8, 2024

Why are these changes needed?

Use a public method instead of access to a private variable.

Related issue number

#1575 #1402

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d675489) 35.23% compared to head (b05cacc) 68.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1592       +/-   ##
===========================================
+ Coverage   35.23%   68.58%   +33.34%     
===========================================
  Files          44       44               
  Lines        5327     5331        +4     
  Branches     1236     1305       +69     
===========================================
+ Hits         1877     3656     +1779     
+ Misses       3296     1325     -1971     
- Partials      154      350      +196     
Flag Coverage Δ
unittests 68.54% <100.00%> (+33.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit 0b4bce2 Feb 8, 2024
56 checks passed
@sonichi sonichi deleted the patch0207 branch February 11, 2024 02:16
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* avoid access private variable

* test chat messages for summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants