Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog regarding finite-state machine #1622

Merged
merged 19 commits into from
Feb 26, 2024
Merged

Blog regarding finite-state machine #1622

merged 19 commits into from
Feb 26, 2024

Conversation

joshkyh
Copy link
Collaborator

@joshkyh joshkyh commented Feb 11, 2024

This is the follow-up blog post on the FSM Group Chat Contribution #857.

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (8ec1c3e) to head (ecb5631).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1622    +/-   ##
========================================
  Coverage   37.05%   37.05%            
========================================
  Files          62       62            
  Lines        6499     6499            
  Branches     1438     1561   +123     
========================================
  Hits         2408     2408            
+ Misses       3898     3897     -1     
- Partials      193      194     +1     
Flag Coverage Δ
unittests 37.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

website/blog/authors.yml Outdated Show resolved Hide resolved
website/blog/authors.yml Outdated Show resolved Hide resolved
website/blog/2024-02-11-FSM-GroupChat/index.mdx Outdated Show resolved Hide resolved
@joshkyh joshkyh changed the title Initialization of fsm blog Blog regarding finite-state machine Feb 15, 2024
@joshkyh
Copy link
Collaborator Author

joshkyh commented Feb 23, 2024

@freedeaths, hope you had a great break. I'll flip this to ready for review if that's ok.

@joshkyh joshkyh marked this pull request as ready for review February 23, 2024 02:10
@freedeaths
Copy link
Contributor

@joshkyh done:)

Copy link
Contributor

@freedeaths freedeaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonichi sonichi added this pull request to the merge queue Feb 25, 2024
@sonichi sonichi removed this pull request from the merge queue due to a manual request Feb 25, 2024
@sonichi
Copy link
Contributor

sonichi commented Feb 25, 2024

@joshkyh Could you modify the corresponding test in test_notebook.py?
Also, add the relevant notebooks into the paths in openai.yml

@joshkyh
Copy link
Collaborator Author

joshkyh commented Feb 26, 2024

@joshkyh Could you modify the corresponding test in test_notebook.py? Also, add the relevant notebooks into the paths in openai.yml

Thanks for the guidance.

Modified test_notebook.py in 7336057.

Regarding paths of openai.yml, I hope I did the right thing in ecb5631...! :)

@sonichi sonichi added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit d797d26 Feb 26, 2024
26 checks passed
@joshkyh joshkyh deleted the fsm-blog branch February 26, 2024 22:51
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Initialization of fsm blog

* Pre-commit pass

* Pinyin name correction

* Updated title

* Updated title

* Added summary of notebook and note about DAG

* Update index.mdx

* Update website/blog/2024-02-11-FSM-GroupChat/index.mdx

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Update website/blog/2024-02-11-FSM-GroupChat/index.mdx

Co-authored-by: Chi Wang <wang.chi@microsoft.com>

* Removed outdated filename and followed SoM notebook format

* Pre-commit pass

* Update notebook link

* Corrected link to rendered notebook

* Removed agentchat_hierarchy_flow_using_select_speaker and modified agentchat_groupchat_finite_state_machine

* Add notebook/agentchat_groupchat_finite_state_machine.ipynb to paths

---------

Co-authored-by: freedeaths <register917@gmail.com>
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants