Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove print config list #1637

Merged
merged 1 commit into from
Feb 12, 2024
Merged

remove print config list #1637

merged 1 commit into from
Feb 12, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 12, 2024

Why are these changes needed?

remove print statement for config list in test.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (899b250) 37.79% compared to head (86729fe) 49.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1637       +/-   ##
===========================================
+ Coverage   37.79%   49.63%   +11.83%     
===========================================
  Files          50       50               
  Lines        5704     5704               
  Branches     1295     1404      +109     
===========================================
+ Hits         2156     2831      +675     
+ Misses       3377     2645      -732     
- Partials      171      228       +57     
Flag Coverage Δ
unittests 49.59% <100.00%> (+11.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job removing this.

@ekzhu
Copy link
Collaborator

ekzhu commented Feb 12, 2024

The test failure is likely due to GPT-3.5 (?)'s indeterministic response. Try re-running it again.

@sonichi sonichi added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 5c58be6 Feb 12, 2024
52 of 60 checks passed
@sonichi sonichi deleted the sanitize branch February 12, 2024 19:29
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants