Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPTAssistantAgent is_termination_msg valid #1642

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

yousonnet
Copy link
Contributor

@yousonnet yousonnet commented Feb 12, 2024

Why are these changes needed?

Related issue number

Checks

@sonichi
Copy link
Contributor

sonichi commented Feb 12, 2024

Code formatting error can be fixed using pre-commit.

Copy link
Collaborator

@gagb gagb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This change is important because otherwise GPTAssistantAgent won't prioritize termination (and human reply) over generating its response even if is_termination_msg or human_input_mode is set.

But please fix the formatting issues.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d01063d) 37.79% compared to head (4ad0d5c) 49.61%.

Files Patch % Lines
autogen/agentchat/contrib/gpt_assistant_agent.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1642       +/-   ##
===========================================
+ Coverage   37.79%   49.61%   +11.81%     
===========================================
  Files          50       50               
  Lines        5704     5706        +2     
  Branches     1295     1404      +109     
===========================================
+ Hits         2156     2831      +675     
+ Misses       3377     2648      -729     
- Partials      171      227       +56     
Flag Coverage Δ
unittests 49.57% <0.00%> (+11.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 13, 2024
Merged via the queue into microsoft:main with commit 81fc749 Feb 13, 2024
46 of 57 checks passed
gunnarku pushed a commit to gunnarku/autogen that referenced this pull request Feb 13, 2024
* add GPTAssistantAgent is_termination_msg valid

* make is_termination_msg in GPTAssistantAgent valid and reformatted

* to pass the black format test
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* add GPTAssistantAgent is_termination_msg valid

* make is_termination_msg in GPTAssistantAgent valid and reformatted

* to pass the black format test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants