-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GPTAssistantAgent is_termination_msg valid #1642
Conversation
Code formatting error can be fixed using pre-commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This change is important because otherwise GPTAssistantAgent
won't prioritize termination (and human reply) over generating its response even if is_termination_msg
or human_input_mode
is set.
But please fix the formatting issues.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
===========================================
+ Coverage 37.79% 49.61% +11.81%
===========================================
Files 50 50
Lines 5704 5706 +2
Branches 1295 1404 +109
===========================================
+ Hits 2156 2831 +675
+ Misses 3377 2648 -729
- Partials 171 227 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* add GPTAssistantAgent is_termination_msg valid * make is_termination_msg in GPTAssistantAgent valid and reformatted * to pass the black format test
* add GPTAssistantAgent is_termination_msg valid * make is_termination_msg in GPTAssistantAgent valid and reformatted * to pass the black format test
Why are these changes needed?
Related issue number
Checks