Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return None instead of tuple in _generate_oai_reply_from_client #1644

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 12, 2024

Why are these changes needed?

Fix a bug in _generate_oai_reply_from_client
which causes test failures when the extracted response is None.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c58be6) 37.79% compared to head (75a6946) 68.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1644       +/-   ##
===========================================
+ Coverage   37.79%   68.12%   +30.32%     
===========================================
  Files          50       50               
  Lines        5704     5704               
  Branches     1295     1404      +109     
===========================================
+ Hits         2156     3886     +1730     
+ Misses       3377     1464     -1913     
- Partials      171      354      +183     
Flag Coverage Δ
unittests 68.11% <100.00%> (+30.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 6d93765 Feb 12, 2024
59 of 60 checks passed
@sonichi sonichi deleted the patch0212 branch February 12, 2024 20:10
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…osoft#1644)

* return None instead of tuple

* return final=False if extracted response is None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants