Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebook contrib guidance, update a few notebooks for site #1651

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Uses ```{=mdx} blocks so fewer \ are needed

Related issue number

#1597

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31a732f) 37.80% compared to head (2e40b5b) 37.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1651   +/-   ##
=======================================
  Coverage   37.80%   37.80%           
=======================================
  Files          50       50           
  Lines        5727     5727           
  Branches     1297     1297           
=======================================
  Hits         2165     2165           
  Misses       3390     3390           
  Partials      172      172           
Flag Coverage Δ
unittests 37.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some syntax changes in the notebook's code blocks. Can you run each of the notebooks locally just to sanity check if they work?

@sonichi sonichi added this pull request to the merge queue Feb 14, 2024
Merged via the queue into microsoft:main with commit a62b5c3 Feb 14, 2024
19 of 23 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…crosoft#1651)

* update some notebooks

* Update contributing.md

* remove os

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants