-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom client registration #1653
Fix custom client registration #1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test just to make sure additional config arguments like cache_seed
won't trigger an error?
Also in test_custom_client.py
(basically all other tests as well, but we don't have to do everything in this PR) we don't need to check for openai
package existence as it is a required dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test just to make sure additional config arguments like cache_seed
won't trigger an error?
Also in test_custom_client.py
(basically all other tests as well, but we don't have to do everything in this PR) we don't need to check for openai
package existence as it is a required dependency.
@ekzhu good point, added unit test, checked that it failed with old code, and passes with PR changes. Also removed the openai req |
Remember to check the code in #1667 also to see if it works with this update. It works on my side. |
* fix custom client registration * fix * add test with extra args
Why are these changes needed?
For custom client registration:
self._config_list
can end up having the extrakwargs
passed through (e.g.cache_seed
) and therefore the check forplaceholder_config
inself._config_list
will failRelated issue number
Checks