Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dotnet workflow #1669

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

LittleLittleCloud
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81fc749) 37.80% compared to head (2d2b6cc) 37.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1669   +/-   ##
=======================================
  Coverage   37.80%   37.80%           
=======================================
  Files          50       50           
  Lines        5727     5727           
  Branches     1297     1297           
=======================================
  Hits         2165     2165           
  Misses       3390     3390           
  Partials      172      172           
Flag Coverage Δ
unittests 37.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I went through the tests haven't found any echoing of secrets.

@LittleLittleCloud LittleLittleCloud added this pull request to the merge queue Feb 13, 2024
@ekzhu ekzhu requested a review from sonichi February 13, 2024 21:31
Merged via the queue into main with commit b05b148 Feb 13, 2024
22 checks passed
@sonichi sonichi deleted the u/xiaoyun/dotnet/updateWorkflow branch February 13, 2024 22:05
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* cherry-pick change in dotnet workflow

* delete openai test workflow as it's part of dotnet-build already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants