Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do model check properly #1686

Merged
merged 3 commits into from
Feb 15, 2024
Merged

do model check properly #1686

merged 3 commits into from
Feb 15, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 15, 2024

Why are these changes needed?

Fix test error introduced by #1654. Move model check from client to ConversableAgent, and modified corresponding tests.

Related issue number

#1522

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d677b47) 39.50% compared to head (1abb998) 61.98%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1686       +/-   ##
===========================================
+ Coverage   39.50%   61.98%   +22.48%     
===========================================
  Files          56       56               
  Lines        5994     5985        -9     
  Branches     1337     1450      +113     
===========================================
+ Hits         2368     3710     +1342     
+ Misses       3431     1944     -1487     
- Partials      195      331      +136     
Flag Coverage Δ
unittests 61.75% <100.00%> (+22.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gunnarku gunnarku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mea culpa. Thank you for fixing my mess. I owe you one.

@sonichi sonichi added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit cff9ca9 Feb 15, 2024
55 of 60 checks passed
@sonichi sonichi deleted the modelcheck branch February 15, 2024 06:05
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* do model check properly

* bug in logging test

* set llm_config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants